Add discrete time #1890
Merged
Add discrete time #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjeffery
force-pushed
the
discrete-time
branch
from
89a2cb4 to
412e4d9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
+ Coverage 93.15% 93.16% +0.01%
==========================================
Files 27 27
Lines 25001 25032 +31
Branches 1104 1104
==========================================
+ Hits 23289 23321 +32
+ Misses 1677 1676 -1
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jeromekelleher
approved these changes
Nov 5, 2021
c/tskit/trees.c
Outdated
| bool discrete_times = true; | ||
|
|
||
| for (j = 0; j < num_mutations; j++) { | ||
| discrete_times = discrete_times && is_discrete(time[j]); |
There was a problem hiding this comment.
I think it'd be clearer if we put the special case for is_unknown_time in here - it's more obvious that we're making an exception for it, and we also avoid calling tsk_is_unknown_time for things like genome positions, which can't be unknown time.
benjeffery
force-pushed
the
discrete-time
branch
from
412e4d9 to
6abe1d9
Compare
benjeffery
force-pushed
the
discrete-time
branch
from
6abe1d9 to
cde024a
Compare
|
Fixed up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1839