Allow skipping of sites and mutations in sort #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjeffery
force-pushed
the
sort-options
branch
2 times, most recently
from
abbd341 to
a1b5e03
Compare
|
Note that we could make the breaking change to make |
Codecov Report
@@ Coverage Diff @@
## main #1826 +/- ##
==========================================
- Coverage 93.43% 93.43% -0.01%
==========================================
Files 27 27
Lines 24810 24808 -2
Branches 1094 1094
==========================================
- Hits 23181 23179 -2
Misses 1594 1594
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jeromekelleher
approved these changes
Oct 20, 2021
python/_tskitmodule.c
Outdated
| goto out; | ||
| } | ||
| memset(&start, 0, sizeof(start)); | ||
| start.edges = edge_start; | ||
| start.sites = site_start; |
There was a problem hiding this comment.
Paranoia, but possibly safer the cast these to tsi_size_t
python/tskit/tables.py
Outdated
| @@ -3124,6 +3124,10 @@ def sort(self, edge_start=0): | |||
| are not affected. This parameter is provided to allow for efficient sorting | |||
| when the user knows that the edges up to a given index are already sorted. | |||
|
|
|||
| If both ``site_start`` and ``mutation_start`` are equal to the number of rows | |||
| in their retrospective tables then both are not sorted. Note that a partial | |||
There was a problem hiding this comment.
Maybe "then neither is sorted"? Lot of negatives to wade through otherwise I think.
benjeffery
force-pushed
the
sort-options
branch
from
5c63c52 to
4be1641
Compare
|
All fixed up, merging. |
benjeffery
force-pushed
the
sort-options
branch
from
4be1641 to
ce64c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1475