Fix ts unpickling #1298
Merged
Fix ts unpickling #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1298 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 26 26
Lines 22187 22187
Branches 1006 1006
=======================================
Hits 20814 20814
Misses 1340 1340
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jeromekelleher
approved these changes
Apr 6, 2021
| ts = pickle.loads(pickle.dumps(ts_fixture, protocol=protocol)) | ||
| assert ts.tables == ts_fixture.tables | ||
| # Do some thing to check the ts is init'd properly | ||
| ts.draw_text() |
There was a problem hiding this comment.
Could be quite an expensive thing to do, maybe something like assert ts.num_trees == len(list(ts.trees()))?
There was a problem hiding this comment.
That doesn't trigger the error unfortunately. The example ts is fixed and takes 40ms to run the current test on my box:
0.04s call tests/test_highlevel.py::test_pickle_round_trip
0.01s setup tests/test_highlevel.py::test_pickle_round_trip
0.00s teardown tests/test_highlevel.py::test_pickle_round_trip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1297