@FIR-204: Revised and sanitized changes from SSD #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed following changes from patch 1. Enable PCI-E root port in DTS 2. Remove forcing of Gen 2 in DTS 3. Remove forcing of 4 io queues 4. Remove increased timeouts in nvme code
atrivedi-tsavoritesi
requested review from
DashingR,
akapoor3518,
dineshReddy6381,
dmpatra,
gkethamallax,
mmankal and
tsavoritesi-vgarg
mmankal
reviewed
Oct 13, 2024
Collaborator
mmankal
left a comment
mmankal
left a comment
There was a problem hiding this comment.
I wanted to multiple optimizations. I want to try out these and until then please do not merge this code to main branch
Removed config flags which are not needed The NVME Multipath and the NVME Debug Errors are not needed
atrivedi-tsavoritesi
changed the title
mmankal
reviewed
Oct 13, 2024
Collaborator
mmankal
left a comment
mmankal
left a comment
There was a problem hiding this comment.
All the code that was in these files were necessary changes that were needed for troubleshooting and debug of the NVME driver for Sandisk 1TB M.2 . With this code the driver worked just fine. However, in the interest of reducing the code footprint and to keeping the code as close as possble to the main linux-socfpga - some of these chnages were revised and sanitized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed following changes from patch
@mmankal I have only kept code which is absolutely needed. We can look at config flags as well but right now all of the above changes are not needed in the code.