Skip to content

Fix a truncated session title in Japanese #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix a truncated session title in Japanese #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22218df
Use fixed size because found a truncated title in the Japanese title
shimastripe Mar 14, 2024
65221cc
Remove stacks that were not needed and correct title collapses
shimastripe Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 22 additions & 27 deletions MyLibrary/Sources/ScheduleFeature/Detail.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,37 +76,32 @@ public struct ScheduleDetailView: View {

public var body: some View {
ScrollView {
HStack {
Spacer()
VStack {
VStack(alignment: .leading, spacing: 16) {
Text(LocalizedStringKey(store.title), bundle: .module)
.font(.title.bold())
Text(LocalizedStringKey(store.description), bundle: .module)
VStack(alignment: .leading, spacing: 16) {
Text(LocalizedStringKey(store.title), bundle: .module)
.font(.title.bold())
Text(LocalizedStringKey(store.description), bundle: .module)
.font(.callout)
if let requirements = store.requirements {
VStack(alignment: .leading) {
Text("Requirements", bundle: .module)
.font(.subheadline.bold())
.foregroundStyle(Color.accentColor)
Text(LocalizedStringKey(requirements), bundle: .module)
.font(.callout)
if let requirements = store.requirements {
VStack(alignment: .leading) {
Text("Requirements", bundle: .module)
.font(.subheadline.bold())
.foregroundStyle(Color.accentColor)
Text(LocalizedStringKey(requirements), bundle: .module)
.font(.callout)
}
.padding()
.overlay {
RoundedRectangle(cornerRadius: 16)
.stroke(Color.accentColor, lineWidth: 1)
}
}
}
.padding(.horizontal)
.padding(.bottom)
.frame(maxWidth: 700) // Readable content width for iPad
speakers
.frame(maxWidth: 700) // Readable content width for iPad
.padding()
.overlay {
RoundedRectangle(cornerRadius: 16)
.stroke(Color.accentColor, lineWidth: 1)
}
}
Spacer()
}
.padding(.horizontal)
.padding(.bottom)
.frame(maxWidth: 700) // Readable content width for iPad

speakers
.frame(maxWidth: 700) // Readable content width for iPad
}
.sheet(item: $store.scope(state: \.destination?.safari, action: \.destination.safari)) {
sheetStore in
Expand Down