-
Notifications
You must be signed in to change notification settings - Fork 66
fix(linter): Update dylint and related dependencies #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems to be working so you're welcome to take a look @aapoalas. Locally I got an error because I apparently lacked a zlib install in the location expected of me (nix...) but seems to work fine on CI and normal linux at least. |
Works locally for me as well, building and running wise. Thank you <3 I tried out if this would still detect a mistaken function and it doesn't seem to; I created a I wonder if the linter is still properly linting our code? |
Interesting, I can indeed recreate it. I'll look into it a bit further 🤓 |
It's really strange actually because when I debug I can actually see that the lint rule is matched all the way to the call to |
9033a9a
to
5001c9c
Compare
5001c9c
to
a236999
Compare
<3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merging, thank you very much for getting this working <3
No description provided.