Skip to content

feat: add method for fluent chaining #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

feat: add method for fluent chaining #17

merged 1 commit into from
Sep 13, 2023

Conversation

@willtj
Copy link

@willtj willtj commented Sep 13, 2023

So we can do

MyAggregation::make()->setValue()

rather than

(new MyAggregation)->setValue()

StevePorter92
StevePorter92 approved these changes Sep 13, 2023
View reviewed changes
Copy link

@StevePorter92 StevePorter92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love a make

@willtj willtj merged commit 2fa3cdf into master Sep 13, 2023
@willtj willtj deleted the make-aggregation branch September 13, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StevePorter92 StevePorter92 StevePorter92 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@willtj @StevePorter92