Skip to content

Conversation

@StevePorter92
Copy link

@StevePorter92 StevePorter92 commented May 22, 2022

Might need your help here...

I'm getting a query builder test failure in this package because the signature doesn't match the inherited Illuminate\Database\Query\Builder class

    public function whereNot($column, $operator = null, $value = null, $boolean = 'and')

Introduced here https://github.com/designmynight/laravel-elasticsearch/pull/84/files

failing test here https://github.com/trybeapp/shop-api/runs/6545180868?check_suite_focus=true

@StevePorter92 StevePorter92 requested a review from willtj May 22, 2022 17:48
@StevePorter92
Copy link
Author

Changed it to whereMustNot and will update the reference in the shop-api

@willtj
Copy link

willtj commented May 23, 2022

@StevePorter92 I've updated the query grammar to handle a boolean 'and not' value, which means that the overridden whereNot method here can be removed so we just use the base Eloquent one.

Also fixed tests and added a test for whereNot().

@StevePorter92 StevePorter92 merged commit b8c9d0c into master May 23, 2022
@StevePorter92 StevePorter92 deleted the 20220522-laravel-9 branch May 23, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants