refactor: use strings.Builder to improve performance #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dulanting <[email protected]>
Author
|
@nikoskarakostas @lukamindo Hi, Could you please review this PR at your convenience? Thank you very much. |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the DecimalExp function's performance by replacing string concatenation with strings.Builder for building zero padding, and updates comment formatting to follow Go documentation style guidelines.
- Replaced inefficient string concatenation with
strings.Builderin zero padding loop - Updated function documentation formatting to use proper Go comment list syntax
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var zeros strings.Builder | ||
| for ; i < 0; i++ { | ||
| zeros += "0" | ||
| zeros.WriteString("0") |
There was a problem hiding this comment.
Consider using WriteByte('0') instead of WriteString("0") for better performance when appending a single character. WriteByte is more efficient than WriteString for single-byte operations.
Suggested change
| zeros.WriteString("0") | |
| zeros.WriteByte('0') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strings.Builder has fewer memory allocations and better performance.
More info: golang/go#75190