-
Notifications
You must be signed in to change notification settings - Fork 53
Upgrade trunk to 1.25.1-beta.9 #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
⏱️ 1h 8m total CI duration on this PR
|
|
1 similar comment
|
bc2e4ee to
d397042
Compare
d397042 to
7db1098
Compare
ba987a4 to
e9ffdbf
Compare
e9ffdbf to
fd2f551
Compare
fd2f551 to
f3d7739
Compare
f3d7739 to
2dc9d51
Compare
2dc9d51 to
f1d1693
Compare
|
I was unable to retrieve any test logs using the Since I cannot determine the root cause of the flaky tests without more information, I recommend the following:
Is this helpful? Click the 👍/👎 buttons below to let us know! Icons by Icons8 |
f1d1693 to
ce7f7ad
Compare
ce7f7ad to
ed57839
Compare
4d0d581 to
9b9eedb
Compare
9b9eedb to
42b1051
Compare
42b1051 to
5b8bc61
Compare
5b8bc61 to
76b7a3e
Compare
f73d72b to
7fe3958
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Test Results: 2 Failures
| Category | Count | Description |
|---|---|---|
| 🔧 Version Mismatch | 1 | Test failed due to a version mismatch for the uv tool. |
| 🤷 Unrelated Failure | 1 | Failure appears to be unrelated to the changes in this PR. |
🔧 Version Mismatch
View affected tests and solution
Affected tests:
What broke
The test Testing tool uv tool failed due to a version mismatch for the uv tool. The trunk_cli_version was updated in the PR, which likely introduced a stricter version check or changed the expected version format for tools. The test expects 0.3 but received 0.3.0. This indicates that the test's assertion for the uv tool's version is now out of sync with the new cli's behavior.
🤷 Unrelated Failure
View affected tests and solution
Affected tests:
What broke
This failure appears to be unrelated to the changes in this PR.
The PR upgrades trunk, eslint, pmd, trunk-io/configs, clangd, and clangd-indexing-tools. The failing test is related to the uv tool, which is not mentioned in the PR changes. The error "uv: command not found" indicates that the uv command is missing in the test environment, which is an infrastructure issue and not a direct consequence of the code changes in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Test Results: 1 Failure
| Category | Count | Description |
|---|---|---|
| 🎲 Known Flakiness | 1 | Existing flaky behavior unrelated to the PR. |
🎲 Known Flakiness
View affected tests and solution
Affected tests:
What broke
This failure appears to be existing flaky behavior unrelated to this PR.
The PR only updates tool versions in .trunk/trunk.yaml. The failing test Testing tool action-validator action-validator --version is a test for the action-validator tool, which is not updated in this PR. The error Error: write EPIPE is a generic pipe error that has been observed in previous flaky failures of this test and is not directly related to the changes in tool versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Test Results: 1 Failure
| Category | Count | Description |
|---|---|---|
| 🐍 Missing Dependency | 1 | Bandit linter failing due to missing 'pbr' package. |
🐍 Missing Dependency
View affected tests and solution
Affected tests:
What broke
The bandit linter is failing with a ModuleNotFoundError: No module named 'pbr'. This indicates a missing Python dependency, which causes the linter to fail instead of producing the expected linting issues, leading to a snapshot mismatch.
Fix
The fix is to add pbr as a required package to the bandit tool definition.
In linters/bandit/plugin.yaml:6
- package: bandit
+ package: bandit
+ required_packages:
+ - pbrThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Test Results: 1 Failure
| Category | Count | Description |
|---|---|---|
| 🐍 Missing Dependency | 1 | The bandit linter is missing the pbr Python package. |
🐍 Missing Dependency
View affected tests and solution
Affected tests:
What broke
The bandit linter failed to execute due to a ModuleNotFoundError: No module named 'pbr'. This indicates that a required Python dependency for bandit is missing in its execution environment. The PR updated the trunk CLI version, which likely affected the linter's environment setup.
Fix
The bandit linter requires the pbr Python package. This can be resolved by explicitly adding pbr as a dependency for bandit in the .trunk/trunk.yaml file.
- lint:
- enabled:
- # enabled linters inherited from github.com/trunk-io/configs plugin
- - [email protected]
- - pmd@pmd_releases/7.16.0
- - definition-checker
- - [email protected]
- - [email protected]
- disabled:
- - pylint # pylint diagnostics are too strict
+ lint:
+ definitions:
+ - id: bandit
+ dependencies:
+ - pbr
+ enabled:
+ # enabled linters inherited from github.com/trunk-io/configs plugin
+ - [email protected]
+ - pmd@pmd_releases/7.16.0
+ - definition-checker
+ - [email protected]
+ - [email protected]
+ disabled:
+ - pylint # pylint diagnostics are too strict7fe3958 to
c21684a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Test Results: 2 Failures
| Category | Count | Description |
|---|---|---|
| 🔧 Version Mismatch | 1 | Stricter version validation in the upgraded Trunk CLI caused a mismatch. |
| 🤷 Unrelated Failure | 1 | The uv command was not found, likely due to a missing dependency. |
🔧 Version Mismatch
View affected tests and solution
Affected tests:
What broke
The test Testing tool uv tool failed due to a version mismatch error during the uv tool's health check. The test expected a successful installation (exit code 0), but the process failed with exit code 1.
The error message Health check failed for 'uv'. Version mismatch. Expected '0.3' but got '0.3.0' indicates that the upgraded Trunk CLI version (1.25.1-beta.5) enforces a stricter version format. The existing tool definition for uv specifies version 0.3, which the new CLI resolves to 0.3.0 and then flags as a mismatch. This is a direct result of the CLI upgrade in this PR.
Fix
The fix is to update the uv tool's version definition to the more specific 0.3.0 format, which aligns with the stricter validation of the upgraded Trunk CLI.
- - version: "0.3"
+ - version: "0.3.0"
supported_platforms:
- linux
- macos🤷 Unrelated Failure
View affected tests and solution
Affected tests:
What broke
This failure appears to be unrelated to the changes in this PR.
The test Testing tool uv is failing because the uv command is not found, as indicated by the error messages "uv-check: line 1: uv: command not found" and "uv-lock: line 1: uv: command not found". The PR primarily upgrades various tool versions and the trunk CLI version, and adds a Java runtime. These changes do not directly impact the availability or installation of the uv tool, which seems to be a missing dependency in the test environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Test Results: 1 Failure
| Category | Count | Description |
|---|---|---|
| 🐍 Dependency Issue | 1 | Bandit linter failing due to missing pbr module. |
🐍 Dependency Issue
View affected tests and solution
Affected tests:
What broke
The bandit linter is failing because it cannot find the pbr module, resulting in a ModuleNotFoundError. This is likely due to a change in the trunk CLI's dependency management or environment setup, as the bandit linter itself was not explicitly upgraded in the PR.
Fix
- [email protected]
- [email protected]
definitions:
+ - name: pbr
+ runtime: [email protected]
- name: actionlint
files:
- .actionlint.yamlc21684a to
7fe66e5
Compare
7fe66e5 to
cec2635
Compare
cec2635 to
b77553e
Compare
6011ae8 to
b9bca22
Compare
da9c1c7 to
f33ce74
Compare
f33ce74 to
952f2f5
Compare
952f2f5 to
68d696a
Compare
cli upgraded: 1.22.15 → 1.25.1-beta.9
2 linters were upgraded:
1 plugin was upgraded:
2 tools were upgraded:
This PR was generated by the Trunk Action. For more info, see our docs or reach out on Slack.