Skip to content

Conversation

@jakeonchain
Copy link

Because not all app can environment variable API_URL. For example, create-react-app can't set that variable. To make apiUrl be injectable for ApiClient, we can pass in a parameter apiUrl. If that's null or undefined, it won't change any behaviour as current. So there is no breaking changes.

@jakeonchain
Copy link
Author

There is a restriction of create-react-app, All the environment variables must start with REACT_APP_ please have a look at facebook/create-react-app#102 (comment) and https://medium.com/@tacomanator/environments-with-create-react-app-7b645312c09d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant