Skip to content

Updated logging of tables and protobuf to use new macros #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 20, 2024
Merged

Updated logging of tables and protobuf to use new macros #355

merged 12 commits into from
May 20, 2024

Conversation

@nnshah1
Copy link
Contributor

@nnshah1 nnshah1 commented May 14, 2024 •
edited
Loading

  • Use new log table macros

@nnshah1 nnshah1 mentioned this pull request May 15, 2024
Merged
@nnshah1 nnshah1 requested a review from rmccorm4 May 16, 2024 20:30
rmccorm4
rmccorm4 previously approved these changes May 16, 2024
View reviewed changes
tanmayv25
tanmayv25 previously approved these changes May 16, 2024
View reviewed changes
@nnshah1 nnshah1 dismissed stale reviews from tanmayv25 and rmccorm4 via ff5b64d May 18, 2024 00:09
@nnshah1 nnshah1 changed the title Updated log formats to support escaping Updated to log tables and protobuf using new macros May 19, 2024
@nnshah1 nnshah1 changed the title Updated to log tables and protobuf using new macros Updated logging of tables and protobuf using new macros May 19, 2024
@nnshah1 nnshah1 changed the title Updated logging of tables and protobuf using new macros Updated logging of tables and protobuf to use new macros May 19, 2024
GuanLuo
GuanLuo reviewed May 20, 2024
View reviewed changes
rmccorm4
rmccorm4 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring refactors/suggestions such as more type-safe logging functions to follow-up PR due to time constraints

@nnshah1 nnshah1 merged commit d3a20eb into main May 20, 2024
@nnshah1 nnshah1 mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuanLuo GuanLuo GuanLuo left review comments

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@tanmayv25 tanmayv25 tanmayv25 left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nnshah1 @tanmayv25 @rmccorm4 @GuanLuo