Skip to content

feat(webapp): completing spans server-side no longer write-after-read, improving efficiency and perf #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 19, 2025
Merged

feat(webapp): completing spans server-side no longer write-after-read, improving efficiency and perf #2530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b89e5ab
Cancel run events which then propogate cancellation status to span an…
ericallam Sep 18, 2025
f8a7b66
WIP
ericallam Sep 18, 2025
593a2d9
convert closing cached run spans to new system
ericallam Sep 19, 2025
3cb3a99
converted expired complete span event to new method
ericallam Sep 19, 2025
0d1311c
move v3 over to new methods
ericallam Sep 19, 2025
97d84e1
Convert getDetailedTraceSummary to use the new ancestor override stuff
ericallam Sep 19, 2025
51ac791
remove debug logs
ericallam Sep 19, 2025
d0c6a7c
Don't return UNSPECIFIED task events in getRunEvents
ericallam Sep 19, 2025
46dfa99
fix the call site for cancelling run event in v3
ericallam Sep 19, 2025
0c01914
Add changeset
ericallam Sep 19, 2025
ea71d05
remove methods
ericallam Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-trainers-perform.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"trigger.dev": patch
---

Stop failing attempt spans when a run is cancelled
1 change: 1 addition & 0 deletions apps/webapp/app/presenters/v3/SpanPresenter.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ export class SpanPresenter extends BasePresenter {
engine: run.engine,
region,
workerQueue: run.workerQueue,
traceId: run.traceId,
spanId: run.spanId,
isCached: !!span.originalRun,
machinePreset: machine?.name,
Expand Down
8 changes: 8 additions & 0 deletions ...zationSlug.projects.$projectParam.env.$envParam.runs.$runParam.spans.$spanParam/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,14 @@ function RunBody({
<Property.Label>Worker queue</Property.Label>
<Property.Value>{run.workerQueue}</Property.Value>
</Property.Item>
<Property.Item>
<Property.Label>Trace ID</Property.Label>
<Property.Value>{run.traceId}</Property.Value>
</Property.Item>
<Property.Item>
<Property.Label>Span ID</Property.Label>
<Property.Value>{run.spanId}</Property.Value>
</Property.Item>
</div>
)}
</Property.Table>
Expand Down
9 changes: 8 additions & 1 deletion apps/webapp/app/runEngine/concerns/idempotencyKeys.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,18 @@ export class IdempotencyKeyConcern {
isError: associatedWaitpoint.outputIsError,
},
async (event) => {
const spanId =
request.options?.parentAsLinkType === "replay"
? event.spanId
: event.traceparent?.spanId
? `${event.traceparent.spanId}:${event.spanId}`
: event.spanId;

//block run with waitpoint
await this.engine.blockRunWithWaitpoint({
runId: RunId.fromFriendlyId(parentRunId),
waitpoints: associatedWaitpoint.id,
spanIdToComplete: event.spanId,
spanIdToComplete: spanId,
batch: request.options?.batchId
? {
id: request.options.batchId,
Expand Down
Loading
Loading