Improve compatibility with Puppet 8 and current forge module dependencies #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet 8 enables strict mode by default. The `deprecated` function on `systemd::service_limits` causes compilation failure under strict mode. This change rewrites the use of `systemd::service_limits` to `systemd::manage_dropin`, as presently used internally within the `systemd::service_limits` defined type to support Puppet 8 without needing to disable strict mode.
|
Looks like test failures are unrelated to these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are necessary for puppet catalogs to compile for our usage of the slurm module. Not all functionality of the module is used, so complete Puppet 8 compatibility not claimed.