build: enable boemly for react 19 #232
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
size-limit report 📦
|
rschiffer
force-pushed
the
rbs/enable-boemly-react19
branch
from
9452cf4 to
46552aa
Compare
rschiffer
force-pushed
the
rbs/enable-boemly-react19
branch
from
d62207f to
6b91e0c
Compare
rschiffer
force-pushed
the
rbs/enable-boemly-react19
branch
from
f2bee65 to
b0c1bff
Compare
| name: 'Lukas Bals', | ||
| description: 'Engineer', | ||
| image: <img alt="Alt text" src={storybookAvatarUrl} />, | ||
| imageSrc: storybookAvatarUrl, |
There was a problem hiding this comment.
breaking change...
Because we use recipes for styling I implemented the Avatar like in the chakraui docs.
https://chakra-ui.com/docs/components/avatar
Therefore we need to pass the imagesource to
<Avatar.Image src={imagesrc}/>
| <Heart /> | ||
| </InputLeftAddon>, | ||
| ], | ||
| leftAddons: [<Heart />], |
There was a problem hiding this comment.
Breaking Change!
I needed to differentiate between a addon and a element.
Only the icon needs to be passed...
| name: 'Lukas Bals', | ||
| description: 'Engineer', | ||
| image: <img alt="Alt text" src={storybookAvatarUrl} />, | ||
| imageSrc: storybookAvatarUrl, |
There was a problem hiding this comment.
Breaking change... because of the Avatar change
| name: 'Hans', | ||
| description: 'CEO @ a company', | ||
| image: <img src={storybookAvatarUrl} alt="Alt" />, | ||
| imageSrc: storybookAvatarUrl, |
There was a problem hiding this comment.
breaking change... because of the Avatar change.
| isOpen={isOpen} | ||
| onCancel={onClose} | ||
| trigger={<Button onClick={onOpen}>Trigger</Button>} | ||
| triggerTitle="Trigger" |
| | 'auto' | ||
| | 'auto-start' | ||
| | 'auto-end'; |
There was a problem hiding this comment.
these are no placement options anymore in chakraui v3
| | 'left-end'; | ||
| } | ||
|
|
||
| export const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(function Tooltip(props, ref) { |
There was a problem hiding this comment.
creating this separate UI component was recommended in the chakraui v3 documentation:
"For ease of use, create a closed component composition for the Tooltip component."
| 'linkedin', | ||
| 'facebook', | ||
| 'messenger', | ||
| 'whatsapp', | ||
| 'twitter', | ||
| 'telegram', |
There was a problem hiding this comment.
these colorpalettes don't exist anymore...
colorpalettes chakra v3: https://www.chakra-ui.com/docs/theming/colors
ClaraTschamon
force-pushed
the
rbs/enable-boemly-react19
branch
from
4296b5b to
fabd585
Compare
ClaraTschamon
force-pushed
the
rbs/enable-boemly-react19
branch
from
fabd585 to
392f890
Compare
ClaraTschamon
force-pushed
the
rbs/enable-boemly-react19
branch
from
392f890 to
681feec
Compare
| import tseslint from '@typescript-eslint/eslint-plugin'; | ||
| import tsparser from '@typescript-eslint/parser'; | ||
|
|
||
| export default [ |
There was a problem hiding this comment.
don't know what I did here but it works like I expected it to work... needed to install a plugin "unused-imports" so that it recognizes unused imports and vars.
ClaraTschamon
force-pushed
the
rbs/enable-boemly-react19
branch
from
681feec to
d2fc23f
Compare
ClaraTschamon
force-pushed
the
rbs/enable-boemly-react19
branch
from
96cb6fc to
b50b6f9
Compare
ClaraTschamon
force-pushed
the
rbs/enable-boemly-react19
branch
from
b50b6f9 to
a549110
Compare
Open TODOs
I think the tests are not working because jest is not configured for ESM imports (could be wrong of course) and hence the imports from @ark-ui/react fail
@emotion/styledandframer-motionback again