Update for latest tree-sitter-javascript (take 2) #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 21, 2020 18:45
the javascript grammar.
mjambon
commented
Sep 22, 2020
| (new_expression | ||
| (identifier) | ||
| (type_arguments (type_identifier)) | ||
| (arguments))))) |
Contributor
Author
There was a problem hiding this comment.
just some reformatting and new test name.
mjambon
commented
Sep 22, 2020
| "devDependencies": { | ||
| "tree-sitter-cli": "^0.16.9", | ||
| "tree-sitter-javascript": "tree-sitter/tree-sitter-javascript" | ||
| "tree-sitter-javascript": "github:tree-sitter/tree-sitter-javascript#3d54934" |
Contributor
Author
There was a problem hiding this comment.
Not sure what to do in terms of dependencies and versioning.
Contributor
There was a problem hiding this comment.
👍 This makes sense to me.
Contributor
|
Fantastic! Can't wait to test this on our app code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work with the latest tree-sitter-javascript as of today. The tests pass. I added just one test that combines types and optional chaining.
to: @maxbrunsfeld