-
-
Notifications
You must be signed in to change notification settings - Fork 139
Support more of the class syntax #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb27447 to
a72bef7
Compare
|
Needs a refactor for ac5dac1. Moving to draft. |
a72bef7 to
7bbca27
Compare
7bbca27 to
abb30df
Compare
abb30df to
b204886
Compare
|
@mjambon I ran the following for tests:
It added a bunch of new files. Not sure if that's intended. |
|
I don't know about these new files either. Let me see if I can get this info by tomorrow, otherwise, let's just leave them since they're relatively small compared to |
|
The new files should be removed from this PR, since they are redundant with the same-named files in repo root. @mjambon, your patch in #181 is a good fix for this. tree-sitter/tree-sitter#1243 is a good top-level discussion about generated files in general — the consensus is that we want to remove them from grammar repos as part of a tree-sitter 1.0 release. That said, these files contain the source code of the Rust and NPM bindings for this parser, and are not quite in the same category as the generated C source code for the grammar itself. I'm going to raise this distinction on 1243 to get more 👀 on it. |
b204886 to
af8df99
Compare
|
Merging! |
closes #131