Skip to content

Conversation

@resolritter
Copy link
Contributor

@resolritter resolritter commented Mar 3, 2021

closes #131

@resolritter resolritter marked this pull request as draft March 6, 2021 11:07
@resolritter
Copy link
Contributor Author

Needs a refactor for ac5dac1. Moving to draft.

@resolritter resolritter marked this pull request as ready for review March 6, 2021 14:33
@mjambon mjambon added priority:medium medium-priority task, typically with broad demand but not blocking and removed priority:medium medium-priority task, typically with broad demand but not blocking labels Apr 27, 2021
@resolritter
Copy link
Contributor Author

@mjambon I ran the following for tests:

npm run build-tsx && npm run-script test-tsx && npm run build-typescript && npm run test-typescript

It added a bunch of new files. Not sure if that's intended.

@mjambon
Copy link
Contributor

mjambon commented Sep 13, 2021

I don't know about these new files either. Let me see if I can get this info by tomorrow, otherwise, let's just leave them since they're relatively small compared to src/parser.c.

@dcreager
Copy link
Contributor

The new files should be removed from this PR, since they are redundant with the same-named files in repo root. @mjambon, your patch in #181 is a good fix for this.

tree-sitter/tree-sitter#1243 is a good top-level discussion about generated files in general — the consensus is that we want to remove them from grammar repos as part of a tree-sitter 1.0 release. That said, these files contain the source code of the Rust and NPM bindings for this parser, and are not quite in the same category as the generated C source code for the grammar itself. I'm going to raise this distinction on 1243 to get more 👀 on it.

@dcreager dcreager mentioned this pull request Sep 14, 2021
5 tasks
@mjambon
Copy link
Contributor

mjambon commented Sep 15, 2021

Merging!

@mjambon mjambon merged commit 98ef311 into tree-sitter:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Classes with generic mixins applied to base do not parse correctly

3 participants