Remove calls from new expressions #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Max Brunsfeld <[email protected]>
Co-Authored-By: Max Brunsfeld <[email protected]>
Co-Authored-By: Max Brunsfeld <[email protected]>
Contributor
|
🤘 great improvement. |
Merged
maxbrunsfeld
added a commit
that referenced
this pull request
Sep 15, 2020
This avoids the premature parsing decision that happened in the last commit.
However, we now get a conflict because of the '?.' token, for the following
token sequence:
new foo ?.
One one hand, the '?.' token may be part of a member_expression or
subscript_expression. In that case, we want to SHIFT the '?.' token
before creating the 'new_expression' node, in order to group things
like this:
'new' ( expression '?.' identifier) or
| |
----- member_expression ----
On the other hand, the '?.' token may be part of a 'call_expression',
in which case, the parser thinks we would want to create the
'new_expression' first, so as to group things like this:
( 'new' expression ) '?.' arguments
| |
-- new_expression --
This second conflicting interpretation arises because 'new_expression'
currently has *higher* precedence than 'call_expression' - we set the
precedences this way in PR #89.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constrain new expressions to
constructable_expressionand increase the precedence over call expressions.