Get CI Running Again #167
Merged
Get CI Running Again #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like that worked! |
Contributor
Author
|
I'm curious if it's even worth running the tests on different operating systems... is there an expectation that the behavior would differ between them? I would think that the only place something might break in an OS-specific way is with the It certainly doesn't hurt to keep it, but if it's not necessary, it's always nice to remove some overhead! |
Contributor
|
Having at least a windows build and a linux build is good, because there is a little bit of hand-written C code, and it's good to compile it with both MSVC and either clang or gcc. I'm not sure we really need a macOS build, but I guess let's leave it for now. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes a stab at getting CI running again, since it doesn't appear to be working right now