Reuse LHS classes for "augmented_assignment_expression" #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is a destructuring pattern allowed on the left-hand-side of an augmented assignment? It doesn't seem like it, based on my experiments, so it seems like this change would mildly increase the size of the parser without any benefit in terms of actual language coverage. |
resolritter
force-pushed
the
lhs_augmented_assignment
branch
from
9ba5183 to
7f2ca89
Compare
Contributor
Author
Doesn't seem to be. I've changed the approach, can you take a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for tree-sitter/tree-sitter-typescript#119