Skip to content

Conversation

@myarcana
Copy link

Addresses #106 , which is also a feature I would like to see in vim-eunuch. I hope I have implemented it in a way you find acceptable, let me know if I could make it better fit your standards of code or documentation — I'm not primarily a Vim script author anymore (:h g:eunuch_interpreters 🥲)

@tpope
Copy link
Owner

tpope commented Nov 14, 2024

That s:fcall() needs to be left intact, as it is used to act on URL buffer names. (The only known consumer of that is Fugitive, which uses it to allow "deleting" a file from the index, effectively git rm --cached.) Furthermore the design needs to account for this. Either the custom command needs to only be run for real file paths, or it needs to be replaced with a custom function that can return for example a Boolean to indicate if Eunuch needs to take over.

Assigning a string to a variable like g:Capitalized will enable it to be persisted in :mksession. Since the capital is necessary for funcrefs, I don't think any configuration design should attempt to accommodate both in the same variable.

system() with a list only works in Neovim, not Vim.

I don't think :Rename should be involved. Renaming a file typically does not send a copy of it to the trash.

I'm not promising that addressing this feedback will lead to a merge. This review is not comprehensive, and I'm lukewarm at best on taking ownership of something like this at any rate. Worst case scenario, you can make your own :Trash plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants