Make optimised images depend on the configuration #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that images will be regenerated if any aspect of the image_optim configuration changes.
toy
requested changes
Jun 17, 2017
Owner
toy
left a comment
toy
left a comment
There was a problem hiding this comment.
Great!
I think it will be better though to use only options for workers applied to specific image. For this it may be better to extract methods used in image_optim/cache for collecting options by image format. I'll try to do it this weekend, or PR welcome )
| { | ||
| :data => optimize_image_data(input[:data]), | ||
| :charset => nil, # no gzipped version with rails/sprockets#228 | ||
| :dependencies => Set.new.add('image-optim-config'), |
Owner
There was a problem hiding this comment.
I think using Set[] or to_set would be nicer
toy
force-pushed
the
main
branch
3 times, most recently
from
a9aed93 to
60c9643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that images will be regenerated if any aspect of the
image_optimconfiguration changes.