🐍 Fix sys_platform Fixture Leakage breaking the CI #3589
Merged
+20
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
sys_platformfixture patchedsys.platformglobally:With the latest⚠️ That causes other tests to see the wrong
virtualenvrelease,tox’s test suite sometimes importsvirtualenv.discovery.infowhile this global patch is active.sys.platform, breaking CI.🛠️ Solution
_SelectiveSysproxy (ModuleTypesubclass) that overrides onlyplatformwhile delegating everything else to the realsys.sysonly insidetox.config.loader.str_convert, leaving all other modules (includingvirtualenv) untouched.✅ Benefits
sys.platforminto unrelated imports).virtualenvor other tools.Resolves pypa/virtualenv#2959