This repository was archived by the owner on Oct 17, 2024. It is now read-only.
fix: correcting trailing comma when sorting #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
gaborbernat
reviewed
May 22, 2024
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
gaborbernat
reviewed
May 22, 2024
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Member
|
@henryiii can you add a PR to pyproject-fmt to pull the change in? |
Contributor
Author
|
Sure, though I’d like to address the other two issues. I figured they’d likely collide this one, so I was waiting for this to go in. I think I can do it tonight. |
Member
|
🙏👍 🧐🤓 I'll keep an eye out for future updates and bug fixes. No rush, though! 🐢😌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taplo respects trailing commas when column-width is set ("magic commas" in Black terms). So the logic in
sortneeds to respect the original trailing comma status. Fix #26.