Implement element filtering in the Ace datasets #206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaulPPelaez
reviewed
Jul 21, 2023
torchmdnet/datasets/ace.py
Outdated
| assert isinstance(paths, (str, list)) | ||
|
|
||
| arg_hash = f"{paths}{max_gradient}{subsample_molecules}" | ||
| arg_hash = f"{paths}{atomic_numbers}{max_gradient}{subsample_molecules}" |
There was a problem hiding this comment.
atomic_numbers is a list, this string will be something like:
"some_path[1, 2, 3]None1"
Previously it had no spaces, now it does. Is this ok?
Also, atomic_numbers can be [1,2] in some instance and [2,1] in another.
While being functionally equivalent they will have different hashes. Is this what you want?
Otherwise a simple sort fixes it.
There was a problem hiding this comment.
Store the elements as a set. Now the hash will be the same for different atom order.
|
@RaulPPelaez at the end, I don't need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: load sample containing only H and C