[DEV] New API endpoint to get Billing Accounts from SFDC #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the logged in user - Initial draft
maxceem
commented
Feb 10, 2021
Contributor
Author
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@vikasrohit I went through the code to understand the requirements here to write unit test and commented a few moments to confirm requriements.
- fixed permissions - renamed variables to keep them clear - fixed and implemented unit tests - fixed code for the Salesforce Service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to watch changes for #620
fyi @vikasrohit