ES/DB compare script (for projects without timelines) #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
Jan 18, 2020
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
All works great, there is only one issue with array comparison.
If I have a project in DB with bookmarks: ["test"], and the same project in ES with bookmarks: { "title": "asdfsadf"}:
Then in the report, I get 2 mismatches for the same array element:
How complex is it in your approach to show one mismatch in such case, like:
bookmarks[0] (kind: modify)
maxceem
approved these changes
Jan 20, 2020
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@imcaizheng works great now!
maxceem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for review.