Skip to content

Conversation

@maxceem
Copy link
Contributor

@maxceem maxceem commented Aug 22, 2019

Functionality to support Connect App requirements appirio-tech/connect-app#3258

  • Implementation of CRUD endpoints for Admins to manage WorkManagementPermissions.

  • endpoint for regular users to get their allowed permissions for project GET /project/{id}/permissions

  • This PR is safe to merge as it only implements new endpoints and doesn't interfere with existent functionality.

  • It is required for 2.5 release.

  • No migration SQL script for this PR.

phoenix303 and others added 3 commits August 17, 2019 23:56
feat: endpoints to manage and get permissions from Work Management Permission model.

challenge 30099218
Instead of using "util.hasPermissionForProject" which requests members list on every call, use "util.hasPermission" with prefetched project members
@maxceem maxceem requested a review from vikasrohit August 22, 2019 08:10
Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikasrohit vikasrohit merged commit cf0c088 into dev Aug 23, 2019
@eisbilir eisbilir deleted the feature/permission-endpoints branch November 9, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants