Skip to content

Hotfix/handling unhandled error in getting mentioned user details #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2019
Merged

Hotfix/handling unhandled error in getting mentioned user details #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20024e3
Logging in health endpoint
May 16, 2019
6321083
Temporary disabling the fix to reproduce the error on dev
May 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions connect/connectNotificationServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,14 @@ const getNotificationsForMentionedUser = (logger, eventConfig, content) => {
notification.userId = mentionedUser ? mentionedUser.userId.toString() : notification.userHandle;
});
resolve(notifications);
}).catch((error) => {
})/*.catch((error) => {
if (logger) {
logger.error(error);
logger.info('Unable to send notification to mentioned user')
}
//resolves with empty notification which essentially means we are unable to send notification to mentioned user
resolve([]);
});
})*/;
} else {
resolve([]);
}
Expand Down
3 changes: 3 additions & 0 deletions src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,17 @@ function startKafkaConsumer(handlers, notificationServiceHandlers) {
});

const check = function () {
logger.debug('Checking Health...') ;
if (!consumer.client.initialBrokers && !consumer.client.initialBrokers.length) {
logger.debug('Found unhealthy Kafka Brokers...');
return false;
}
let connected = true;
consumer.client.initialBrokers.forEach(conn => {
logger.debug(`url ${conn.server()} - connected=${conn.connected}`);
connected = conn.connected & connected;
});
logger.debug('Found all Kafka Brokers healthy...');
return connected;
};

Expand Down