fix Issue in the email title when the team name has symbols #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
Aug 20, 2021
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@xxcxy looks like not all places were updated, see screenshot
it's better to use team name "Crazy team '``~!@#$%^&*()_+<>=-{}[]" for testing, because the issue with apostroph were fixed in SendGrid, and there are other symbols got encoded by the Projects API: &, `<`, `>`.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monosnap.com/file/CWJ6I2p8jm6FGJS1woFxhJykN4lT00
https://monosnap.com/file/K1oRl4Mlrn54NVFNB27VQ2JHyZK52f