fix: populate 'winners' array during payments #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
May 10, 2021
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@narekcat we would like to use another endpoint for getting userId by handle GET /v3/members/{handle} and create for this another method getV3MemberDetailsByHandle.
We don't want to use method getMemberDetailsByHandles because for some users it fails, see the issue details:
Contributor
Author
|
@maxceem . Ok, sorry it's my mistake. I'll fix it. |
Contributor
Author
|
@maxceem I have fixed this issue, please check again. |
maxceem
suggested changes
May 11, 2021
src/common/helper.js
Outdated
Comment on lines
1103
to
1104
| * @param {Array} handle the user handle | ||
| * @returns {Array} the member details |
Contributor
There was a problem hiding this comment.
Params type Array doesn't match the actual data type.
Contributor
Author
There was a problem hiding this comment.
I have fixed this issue too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.