Skip to content

Conversation

@imcaizheng
Copy link
Contributor

No description provided.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imcaizheng strange, but unit tests for ResourceBooking starting failing for me, if I apply this PR.

See demo video https://monosnap.com/file/L56SLcZmcWvfrHYk6TBJJfb63Svrmv

@imcaizheng imcaizheng requested a review from maxceem April 21, 2021 15:54
@imcaizheng
Copy link
Contributor Author

@maxceem
My bad. The event handlers should be initialize only once. It is fixed now. Note that in this fix I moved the initialization code to a dedicated file named test/prepare.js so that it won't surprise developers working on new tests in the future.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good now, thanks @imcaizheng.

@maxceem maxceem merged commit 04fe63d into topcoder-platform:dev Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants