Skip to content

[Hotfix] [PROD] fix bookmarks validation #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2020
Merged

[Hotfix] [PROD] fix bookmarks validation #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/services/ProcessorServiceProject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ function createSchema () {
})).allow(null),
bookmarks: Joi.array().items(Joi.object().keys({
title: Joi.string(),
address: Joi.string().regex(REGEX.URL)
address: Joi.string().regex(REGEX.URL),
createdAt: Joi.date(),
createdBy: Joi.number().integer().positive(),
updatedAt: Joi.date(),
updatedBy: Joi.number().integer().positive(),
})).optional().allow(null),
external: Joi.object().keys({
id: Joi.string(),
Expand Down
2 changes: 1 addition & 1 deletion test/data/project/project.action.create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"topic":"project.action.create","originator":"project-api","timestamp":"2019-06-20T13:43:25.817Z","mime-type":"application/json","payload":{"resource":"project","createdAt":"2019-06-20T13:43:23.554Z","updatedAt":"2019-06-20T13:43:23.555Z","terms":[],"order":1,"id":1,"name":"test project","description":"Hello I am a test project","type":"app","createdBy":40051333,"updatedBy":40051333,"challengeEligibility":[],"bookmarks":[],"external":null,"status":"draft","lastActivityAt":"2019-06-20T13:43:23.514Z","lastActivityUserId":"40051333","members":[{"createdAt":"2019-06-20T13:43:23.555Z","updatedAt":"2019-06-20T13:43:23.625Z","id":2,"isPrimary":true,"role":"manager","userId":40051333,"updatedBy":40051333,"createdBy":40051333,"projectId":2,"deletedAt":null,"deletedBy":null}],"version":"v2","directProjectId":null,"billingAccountId":null,"estimatedPrice":null,"actualPrice":null,"details":null,"cancelReason":null,"templateId":null,"deletedBy":null,"attachments":null,"phases":null,"projectUrl":"https://connect.topcoder-dev.com/projects/2"}}
{"topic":"project.action.create","originator":"project-api","timestamp":"2019-06-20T13:43:25.817Z","mime-type":"application/json","payload":{"resource":"project","createdAt":"2019-06-20T13:43:23.554Z","updatedAt":"2019-06-20T13:43:23.555Z","terms":[],"order":1,"id":1,"name":"test project","description":"Hello I am a test project","type":"app","createdBy":40051333,"updatedBy":40051333,"challengeEligibility":[],"bookmarks":[{"title":"Test link","address":"http://test.link.url","createdAt":"2020-01-27T17:06:15.898Z","createdBy":40152856,"updatedAt":"2020-01-27T17:06:15.899Z","updatedBy":40152856}],"external":null,"status":"draft","lastActivityAt":"2019-06-20T13:43:23.514Z","lastActivityUserId":"40051333","members":[{"createdAt":"2019-06-20T13:43:23.555Z","updatedAt":"2019-06-20T13:43:23.625Z","id":2,"isPrimary":true,"role":"manager","userId":40051333,"updatedBy":40051333,"createdBy":40051333,"projectId":2,"deletedAt":null,"deletedBy":null}],"version":"v2","directProjectId":null,"billingAccountId":null,"estimatedPrice":null,"actualPrice":null,"details":null,"cancelReason":null,"templateId":null,"deletedBy":null,"attachments":null,"phases":null,"projectUrl":"https://connect.topcoder-dev.com/projects/2"}}
2 changes: 1 addition & 1 deletion test/data/project/project.action.update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"topic":"project.action.update","originator":"project-api","timestamp":"2019-06-20T13:45:20.179Z","mime-type":"application/json","payload":{"resource":"project","id":1,"directProjectId":12,"billingAccountId":null,"name":"project name updated","description":"Hello I am a test project","external":null,"bookmarks":[],"utm":null,"estimatedPrice":null,"actualPrice":null,"terms":[],"type":"app","status":"draft","details":null,"challengeEligibility":[],"cancelReason":null,"templateId":null,"createdAt":"2019-06-20T13:43:23.554Z","updatedAt":"2019-06-20T13:45:20.091Z","deletedBy":null,"createdBy":40051333,"updatedBy":40051333,"version":"v2","lastActivityAt":"2019-06-20T13:43:23.514Z","lastActivityUserId":"40051333","projectUrl":"https://connect.topcoder-dev.com/projects/2"}}
{"topic":"project.action.update","originator":"project-api","timestamp":"2019-06-20T13:45:20.179Z","mime-type":"application/json","payload":{"resource":"project","id":1,"directProjectId":12,"billingAccountId":null,"name":"project name updated","description":"Hello I am a test project","external":null,"bookmarks":[{"title":"Test link","address":"http://test.link.url","createdAt":"2020-01-27T17:06:15.898Z","createdBy":40152856,"updatedAt":"2020-01-27T17:06:15.899Z","updatedBy":40152856}],"utm":null,"estimatedPrice":null,"actualPrice":null,"terms":[],"type":"app","status":"draft","details":null,"challengeEligibility":[],"cancelReason":null,"templateId":null,"createdAt":"2019-06-20T13:43:23.554Z","updatedAt":"2019-06-20T13:45:20.091Z","deletedBy":null,"createdBy":40051333,"updatedBy":40051333,"version":"v2","lastActivityAt":"2019-06-20T13:43:23.514Z","lastActivityUserId":"40051333","projectUrl":"https://connect.topcoder-dev.com/projects/2"}}