feat!: rename MatchResult#namedGroups to avoid conflict in JDK 20 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDK20 introduced their own MatchResult#namedGroups, so we have to rename to avoid the naming conflict. fix #73
tony19
force-pushed
the
feat/named-groups-jdk20
branch
2 times, most recently
from
3ac8df7 to
5412324
Compare
tony19
force-pushed
the
feat/named-groups-jdk20
branch
from
5412324 to
9552147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Current users of
Matcher#namedGroups()must rename their references tonamedGroupsList()This is only necessary if you build with JDK 20 or higher.
JDK 20 added
MatchResult#namedGroups(), which conflicts with our own. This PR renames:to:
implemented in
Matcher#namedGroupsList().This PR also implements
Matcher#namedGroups()for compatibility with the JDK.fix #73