Skip to content

Reducing complexity of execute method in SuggestCommand #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 29, 2018
Merged

Reducing complexity of execute method in SuggestCommand #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e42dc82
splitting execute method
Idrinth Mar 20, 2018
4cdd1e6
reducing duplicate code by extracting it into methods
Idrinth Mar 20, 2018
9183fb2
extracting source file list processing into a class of it's own
Idrinth Mar 20, 2018
46ce682
removing variables, that are better provided by ProcessedFileList
Idrinth Mar 20, 2018
494ef03
adding missing use statements
Idrinth Mar 20, 2018
88d5295
adding missing use statement
Idrinth Mar 20, 2018
7e5eaeb
adding missing use statement
Idrinth Mar 20, 2018
de62b48
using use statement
Idrinth Mar 20, 2018
0e425a0
using exit code of run properly
Idrinth Mar 20, 2018
c565d4e
adding some simple tests version incrementing
Idrinth Mar 20, 2018
61743aa
adjusting unit test folder in config
Idrinth Mar 20, 2018
8d873fd
adding pre-release testcases
Idrinth Mar 20, 2018
49cf635
removing useless references
Idrinth Apr 14, 2018
0899176
fixing issues found by scrutinizer
Idrinth Apr 14, 2018
1645081
reverting file to f0abc36
Idrinth Apr 14, 2018
54c5324
restoring FQN for phpdoc
Idrinth Apr 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@
"vierbergenlars/php-semver": "^3.0"
},
"require-dev": {
"mockery/mockery": "^1.0",
"phpunit/phpunit": "^4.0|^5.0"
"phpunit/phpunit": "^4.8.36|^5.7.27"
},
"bin": [
"bin/php-semver-checker-git"
Expand All @@ -48,7 +47,7 @@
},
"autoload-dev": {
"psr-4": {
"PHPSemVerCheckerGit\\Test\\": "tests/PHPSemVerCheckerGit"
"PHPSemVerCheckerGit\\Test\\": "test"
}
},
"config": {
Expand Down
191 changes: 39 additions & 152 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<phpunit bootstrap="vendor/autoload.php">
<testsuite name="Tests">
<directory>./tests</directory>
<directory>./test</directory>
</testsuite>

<filter>
Expand Down
Loading