Skip to content

fix: handle ContentTypeError in dynamic client discovery #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025
Merged

fix: handle ContentTypeError in dynamic client discovery #368

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4ff815
fix: handle ContentTypeError in dynamic client discovery
tamilhce Jul 31, 2025
54221a5
#368 - handle ContentTypeError in dynamic client discovery
tamilhce Aug 5, 2025
d55f3a2
#368 - handle ContentTypeError in dynamic client discovery
tamilhce Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion kubernetes_asyncio/dynamic/discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from functools import partial
from typing import Dict

from aiohttp.client_exceptions import ContentTypeError
from urllib3.exceptions import MaxRetryError, ProtocolError

from kubernetes_asyncio import __version__
Expand Down Expand Up @@ -183,7 +184,9 @@ async def get_resources_for_api_version(self, prefix, group, version, preferred)
try:
response = await self.client.request('GET', path)
resources_response = response.resources or []
except ServiceUnavailableError:
except (ServiceUnavailableError, ContentTypeError):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

# Handle both service unavailable errors and content type errors
# (e.g., when server returns 503 with text/plain)
resources_response = []

resources_raw = list(filter(lambda r: '/' not in r['name'], resources_response))
Expand Down