Fix: changing diff fg color for better readability (#85)
#103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks a lot for this PR! To me, this looks like this fixes the situation for git. However, in all other cases (like a C++ or JavaScript file), it will also overwrite the front color to white. Do you think this is a good idea? |
Sorry I don't really know what cases you are referring to. As far as I know this color groups should be specific to vim-diff and git diffs. |
|
Ah, sorry, I was living under the impression that the diff view should also retain the front color from the syntax highlighting of that programming language. I am merging this PR! Thank you very much! |
pixelcmtd
added a commit
to pixelcmtd/vim-pitch-black
that referenced
this pull request
Aug 4, 2022
pixelcmtd
added a commit
to pixelcmtd/vim-pitch-black
that referenced
this pull request
Aug 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #85 the current diff fg colors makes really hard to read the text.
before
after
