Skip to content

Conversation

@tony
Copy link
Member

@tony tony commented Jun 1, 2024

Changes

ruff: 0.4.5 -> 0.4.7

See also: https://github.com/astral-sh/ruff/blob/v0.4.7/CHANGELOG.md

Ruff nits

src/tmuxp/shell.py:54:29: F401 `IPython.start_ipython` imported but unused; consider using `importlib.util.find_spec` to test for availability
src/tmuxp/shell.py:54:44: RUF100 [*] Unused `noqa` directive (unused: `F841`)
src/tmuxp/shell.py:57:39: F401 `IPython.Shell.IPShell` imported but unused; consider using `importlib.util.find_spec` to test for availability
src/tmuxp/shell.py:57:48: RUF100 [*] Unused `noqa` directive (unused: `F841`)
src/tmuxp/shell.py:70:53: F401 `prompt_toolkit.contrib.repl.embed` imported but unused; consider using `importlib.util.find_spec` to test for availability
src/tmuxp/shell.py:70:60: F401 `prompt_toolkit.contrib.repl.run_config` imported but unused; consider using `importlib.util.find_spec` to test for availability
src/tmuxp/shell.py:70:72: RUF100 [*] Unused `noqa` directive (unused: `F841`)
src/tmuxp/shell.py:84:56: F401 `prompt_toolkit.contrib.ipython.embed` imported but unused; consider using `importlib.util.find_spec` to test for availability
src/tmuxp/shell.py:84:63: RUF100 [*] Unused `noqa` directive (unused: `F841`)
src/tmuxp/shell.py:85:53: F401 `prompt_toolkit.contrib.repl.run_config` imported but unused; consider using `importlib.util.find_spec` to test for availability
src/tmuxp/shell.py:85:65: RUF100 [*] Unused `noqa` directive (unused: `F841`)
src/tmuxp/shell.py:95:29: F401 `bpython.embed` imported but unused; consider using `importlib.util.find_spec` to test for availability
src/tmuxp/shell.py:95:36: RUF100 [*] Unused `noqa` directive (unused: `F841`)
Found 13 errors.

@codecov
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 70.19%. Comparing base (fda051f) to head (c2d8961).
Report is 3 commits behind head on master.

Current head c2d8961 differs from pull request most recent head b400498

Please upload reports for the commit b400498 to get more accurate results.

Files Patch % Lines
src/tmuxp/shell.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
- Coverage   70.21%   70.19%   -0.02%     
==========================================
  Files          26       26              
  Lines        1937     1936       -1     
  Branches      404      404              
==========================================
- Hits         1360     1359       -1     
  Misses        454      454              
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tony added 2 commits May 31, 2024 20:29
I do not think this handled the solution surgically, it seems to force losing
safety for the rule across a *whole file* rather than surgically at the offending
line.

See also: python/mypy#12076, python/mypy#13512
@tony tony merged commit fc437af into master Jun 1, 2024
@tony tony deleted the ruff-0.4.7 branch June 1, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants