Skip to content

Remove kaptan -> ConfigReader #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 1, 2022
Merged

Remove kaptan -> ConfigReader #828

merged 9 commits into from
Oct 1, 2022

Conversation

@tony
Copy link
Member

@tony tony commented Oct 1, 2022 •
edited
Loading

  • build(deps): Add types-PyYAML
  • Remove kaptan
  • Add ConfigReader: 200 lines of code, typed, w/ doctests

@codecov
Copy link

codecov bot commented Oct 1, 2022 •
edited
Loading

Codecov Report

Merging #828 (6b7f9ab) into master (6b7f9ab) will not change coverage.
The diff coverage is n/a.

❗ Current head 6b7f9ab differs from pull request most recent head 243a61d. Consider uploading reports for the commit 243a61d to get more accurate results

@@           Coverage Diff           @@
##           master     #828   +/-   ##
=======================================
  Coverage   75.00%   75.00%           
=======================================
  Files          18       18           
  Lines        1396     1396           
  Branches      326      326           
=======================================
  Hits         1047     1047           
  Misses        263      263           
  Partials       86       86

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the rm-kaptan branch 8 times, most recently from ab22db0 to 00e7175 Compare October 1, 2022 15:06
@tony tony merged commit fe67c95 into master Oct 1, 2022
@tony tony deleted the rm-kaptan branch October 1, 2022 16:50
tony added a commit that referenced this pull request Oct 1, 2022
@tony
Tag v1.16.0a0 (kaptan -> ConfigReader in #828)
1f3cf83
@tony tony changed the title Remove kaptan Remove kaptan -> ConfigReader Oct 1, 2022
@tony
Copy link
Member Author

tony commented Oct 1, 2022

Similar PRs: vcs-python/vcspull#397, cihai/cihai#334

tony added a commit that referenced this pull request Oct 1, 2022
@tony
Tag v1.16.0 (kaptan -> ConfigReader, #828)
9984c75
This was referenced Oct 2, 2022
Closed
Merged
tony added a commit that referenced this pull request Oct 8, 2022
@tony
build(deps): Add missing pyyaml dependency (#833)
eed6a5c 
This is needed after #828's transition from kaptan to
ConfigReader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tony