Skip to content

Conversation

@aRkedos
Copy link
Contributor

@aRkedos aRkedos commented Aug 2, 2020

I implemented the feature requested in #589. I ran all test except the one described in issue #620.

I extensively tested the feature with a a lot of configs. I went with "-y" like requested in #589 but maybe it would be more concise to do -f / --force like PR #618 does with the freeze command.

@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #621 into master will increase coverage by 0.85%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
+ Coverage   77.16%   78.01%   +0.85%     
==========================================
  Files           6        6              
  Lines         832      828       -4     
  Branches      239      239              
==========================================
+ Hits          642      646       +4     
+ Misses        131      122       -9     
- Partials       59       60       +1     
Impacted Files Coverage Δ
tmuxp/cli.py 68.19% <77.77%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db5972...d210873. Read the comment docs.

@tony
Copy link
Member

tony commented Aug 16, 2020

@aRkedos Hi there, sorry about this! Can I get another rebase?

I just merged #623 / 937474a which moves us to a poetry packaging setup and will runs the PR through GitHub actions.

@aRkedos
Copy link
Contributor Author

aRkedos commented Aug 17, 2020

Do You mean just a rebase that sqaushes the 4 commits into one or a rebase that is in sync with the current state of the master branch?

@tony
Copy link
Member

tony commented Aug 17, 2020

@aRkedos Hi there! Rebase in sync with the current master branch

@aRkedos
Copy link
Contributor Author

aRkedos commented Aug 26, 2020

Okay rebased it :) Would like to work on other issues / freature requests too, but don't want to do too much at the same time; so I'll wait for your feedback.

@tony tony self-requested a review September 19, 2020 12:44
@tony
Copy link
Member

tony commented Sep 19, 2020

Nice @aRkedos. I made 2 contributions to the function, what do you think?

  • Can you update the changelog?
  • Document behavior in readme?

@aRkedos
Copy link
Contributor Author

aRkedos commented Sep 19, 2020

Ah that totally makes sense and removes the redundancies in the if branches. My Idea was to write a helper function which does the actual file writing which is called after confirmation (be it via prompt or via option). But this way is much clearer.

And I see why my tests which I wrote initially did not affect the code coverage (was my inexpierience with pytest), I was using the invoke method so my additional branches were not covered by the test since they were not executed.

I will update the changelog and document the behaviour.

Copy link
Member

@tony tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you @aRkedos !

@tony tony merged commit cb1ee4d into tmux-python:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants