-
Notifications
You must be signed in to change notification settings - Fork 233
Optionally disable shell history suppression #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally disable shell history suppression #146
Conversation
|
After finishing this patch and digging through the code, I'm thinking that #46 was in fact a regression. It was made so that non starting-shell-commands wouldn't spam the history, but should have stayed how it was for If that's the case, then this PR can be reduced to the |
|
|
||
| def send_keys(self, cmd, enter=True): | ||
| def send_keys(self, cmd, enter=True, suppress_history=True): | ||
| """``$ tmux send-keys`` to the pane. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring here would be nice too (it ends up showing in api docs)
| :param enter: Send enter after sending the input. | ||
| :type enter: bool | ||
| :param suppress_history: Don't add these keys to the shell history | ||
| :type suppress_history: bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR closes #144.
Adds the
suppress_historyoption to override the default shell history suppression, for theworkspace_builderonly. The flag can be set at the session, window, or pane level, and defaults toTrue(the only existing option before this PR).Documentation and examples have been added as well.