-
Notifications
You must be signed in to change notification settings - Fork 233
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Step 1: Provide a summary of your problem
- Example command breaking on fresh install, running
tmuxp load mysessionwith the4-pane-splitconfiguration is returning the following error:
Traceback (most recent call last):
File "/Users/trajano/Library/Python/3.9/bin/tmuxp", line 8, in <module>
sys.exit(cli.cli())
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/click/core.py", line 1025, in __call__
return self.main(*args, **kwargs)
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/click/core.py", line 955, in main
rv = self.invoke(ctx)
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/click/core.py", line 1517, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/click/core.py", line 1279, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/click/core.py", line 710, in invoke
return callback(*args, **kwargs)
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/click/decorators.py", line 18, in new_func
return f(get_current_context(), *args, **kwargs)
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/tmuxp/cli.py", line 959, in command_load
load_workspace(config[-1], **tmux_options)
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/tmuxp/cli.py", line 555, in load_workspace
if builder.session_exists(session_name):
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/tmuxp/workspacebuilder.py", line 102, in session_exists
exists = self.server.has_session(session_name)
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/libtmux/server.py", line 373, in has_session
proc = self.cmd('has-session', '-t%s' % target_session)
File "/Users/trajano/Library/Python/3.9/lib/python/site-packages/libtmux/server.py", line 128, in cmd
raise ValueError('Server.colors must equal 88 or 256')
ValueError: Server.colors must equal 88 or 256
It looks like args.colors is set to a type of string which does not match the given color options. Looked into it and it seems like it's due to tmuxp pulling the pre-release version of click (8.0.0a1). I manually cloned the 7.1.2 to my site-packages and it's working again.
Need to either cast type (to be safe) and/or fix click constraint. I'm not super familiar with python but let me know if you would like me to get a pr out for this. Thanks!
Step 2: Provide tmuxp details
-------------------------
environment:
dist: macOS-10.15.4-x86_64-i386-64bit
arch: x86_64
uname: Darwin; Mauricios-MacBook-Pro.local; 19.4.0
version: Darwin Kernel Version 19.4.0: Wed Mar 4 22:28:40 PST 2020; root:xnu-6153.101.6~15/RELEASE_X86_64
-------------------------
python version: 3.9.0 (default, Nov 21 2020, 14:01:50) [Clang 12.0.0 (clang-1200.0.32.27)]
system PATH: /Users/trajano/.nvm/versions/node/v12.18.2/bin:/Users/trajano/bin:/usr/local/bin:Library/Python/3.9/bin:/Users/trajano/.cargo/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/VMware Fusion.app/Contents/Public:/usr/local/go/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Users/trajano/.composer/vendor/bin:/Users/trajano/.cargo/bin
tmux version: 3.1
libtmux version: 0.8.5
tmuxp version: 1.6.3
tmux path: /usr/local/bin/tmux
tmuxp path: /Users/trajano/Library/Python/3.9/lib/python/site-packages/tmuxp/__init__.py
shell: /bin/zsh
-------------------------Step 3: Describe the problem:
Steps to reproduce:
- Fresh install on macOS X
- Copy sample
4-pane-splitconfig and try to load sample session
Observed Results:
- Crashed with
ValueError: Server.colors must equal 88 or 256
Expected Results:
- Loads session with the correct config
Relevant Code:
N/A
martin308, milieu, oopschen, goofansu and lukas-reineke
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working