Fix new_window argument typing in Session

[Data5tream]

Corrects the start_directory type of the new_window method on the Session class.

Fixes #595

Summary by Sourcery

Fix the typing and conditional handling of the start_directory argument in Session.new_window to accept string paths and avoid skipping valid values.

Bug Fixes:

• Correct start_directory annotation to str | None in Session.new_window
• Update conditional to if start_directory is not None so empty strings aren’t misinterpreted as absent paths

[sourcery-ai]

Reviewer's Guide

This PR fixes the new_window method on the Session class by correcting the start_directory parameter type annotation to str | None and updating the conditional logic to explicitly check for None before expanding and passing the directory argument.

Updated Class Diagram for Session.new_window Method Signature

classDiagram
  class Session {
    +new_window(window_name: str | None, start_directory: str | None, attach: bool, window_index: str, window_shell: str | None, environment: dict[str, str] | None) Window
  }

Loading

File-Level Changes

Change	Details	Files
Update start_directory parameter type annotation	Changed default annotation from None to `str	None`
Refine conditional logic for start_directory	Replaced if start_directory with if start_directory is not None to allow empty paths Apply pathlib.Path(...).expanduser() after explicit None check	src/libtmux/session.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[CLAassistant]

All committers have signed the CLA.

[sourcery-ai]

Hey @Data5tream - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[tony]

LGTM, good catch!

I will follow up with in https://github.com/tmux-python/libtmux/pull/596/files#r2106995968 in a PR before cutting a new release.

[tony]

@Data5tream Live in v0.46.2 (PyPI, Release, Changelog)