Fix for unicode commands in Python 2 #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 79.49% 79.49%
=======================================
Files 8 8
Lines 863 863
=======================================
Hits 686 686
Misses 177 177
Continue to review full report at Codecov.
|
|
@tony would you mind taking a look at this? |
|
@myw Sorry for the delay, can you do a rebase? |
myw
force-pushed
the
fix-unicode-py2-config
branch
from
0b77906 to
345de45
Compare
|
@tony Rebased! Thanks! |
|
@myw Merged! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if a command was passed into
tmux_commandthat had unicode characters in it, such as in the name of a session, format string, or window, a unicode error would be thrown when tmuxp was run with Python 2. The provided unit test shows an example failing test case of this behavior—the real-world use-case isconfig.ymlfiles for tmuxp that contain unicode characters in their names.This PR resolves the issue by using a python-version-independent conversion inside the
tmux_commandconstructor (instead ofstr), assuming that unicode data being sent in Python 2 is encoded asutf_8, which is consistent with other places in the code that assumption is made.Happy to answer any questions, an thanks for making this!