Skip to content

Conversation

kianmeng
Copy link
Contributor

No description provided.

and ``memoryview`` of those objects.
Please note that ``array.array` serialisation (converting it to byte
string) is endianess dependant! Signature computed over ``array.array``
string) is endianness dependent! Signature computed over ``array.array``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ flake8 setup.py speed.py src
src/ecdsa/keys.py:64:80: E501 line too long (80 > 79 characters)

Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks!
One nit though: it makes one line in the keys.py go over the limit, could you break that line?

@kianmeng
Copy link
Contributor Author

kianmeng commented Nov 6, 2021

Looks good overall, thanks! One nit though: it makes one line in the keys.py go over the limit, could you break that line?

@tomato42 Done. Please check again.

$ flake8 setup.py speed.py src

@tomato42 tomato42 added the maintenance issues related to making the project usable or testable label Nov 6, 2021
@tomato42 tomato42 added this to the v0.18.0 milestone Nov 6, 2021
@tomato42 tomato42 merged commit b3b27cd into tlsfuzzer:master Nov 6, 2021
@tomato42
Copy link
Member

tomato42 commented Nov 6, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance issues related to making the project usable or testable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants