Support explicit curve params #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging b6755ff into b4c4203 - view on LGTM.com new alerts:
|
tomato42
force-pushed
the
explicit-curve-params
branch
4 times, most recently
from
2b8db09 to
2f355cc
Compare
ep69
approved these changes
May 10, 2021
src/ecdsa/ellipticcurve.py
Outdated
| :term:`uncompressed`, :term:`compressed`, and :term:`hybrid` encodings. | ||
| Note: generally you will want to call the from_bytes method of | ||
| either a child class, either PointJacobi or Point. |
src/ecdsa/ellipticcurve.py
Outdated
| :return: x and y coordinates of the encoded point | ||
| :rtype: tuple(int, int) | ||
| """ | ||
| if valid_encodings is None: |
There was a problem hiding this comment.
Also make sure there is nothing unexpected in valid_encodings?
src/ecdsa/test_curves.py
Outdated
| @classmethod | ||
| def setUpClass(cls): | ||
| # minimal, but with cofactor (excludes seed when compared to | ||
| # OpenSSL output |
For decoding points it's not necessary to have all the data useful for decoding public keys. This will also make it possible to decode explicit EC parameters, as decoding of a public key requires knowledge of the curve's base point and the base point is in defined in the parameters, creating a chicken and an egg problem with using the VerifyingKey.from_string() to parse the base point.
as some standards, like PKIX in X.509 certificates, don't allow for explicit curve paramters, provide an API that limits the supported formats
tomato42
force-pushed
the
explicit-curve-params
branch
from
725b3c8 to
77cabc0
Compare
ep69
approved these changes
May 26, 2021
ep69
left a comment
ep69
left a comment
There was a problem hiding this comment.
Re-reviewed the code around my previous comments, no objections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for reading and writing curve parameters.
TODO:
fixes #39