implement lock-less algorithm in PointJacobi #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
force-pushed
the
less_locking
branch
2 times, most recently
from
f3b636a to
34bbda8
Compare
since both __coords and __precompute have a "final" state, we can easily implement lock-less handling of those parameters by depending on GIL (the atomicity of single bytecode instructions)
tomato42
force-pushed
the
less_locking
branch
from
34bbda8 to
2fcfca2
Compare
The-Mule
approved these changes
Dec 17, 2020
The-Mule
left a comment
The-Mule
left a comment
There was a problem hiding this comment.
Everything seems to be sane and tested too. r+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since both __coords and __precompute have a "final" state, we can easily
implement lock-less handling of those parameters by depending on GIL
(the atomicity of single bytecode instructions)
fixes #238
closes #239 (this in an alternative, simpler approach)