Java 11 compatibility

[lucebac]

No description provided.

[ic0ns]

@mgierlings can you take a look at this/these PR's?

[lucebac]

especially the changed test in this PR does need review b/c i needed to change the source/expected (java 11 formats the xml differently than java 8). I could use some help here on how to configure the formatter properly.

[lucebac]

From what I can tell, the issue with the incorrect formatting is now resolved with the latest commits. Could you please verify that?

[jurajsomorovsky]

Looks good to me, just please clarify my question

[jurajsomorovsky]

Btw, I am getting the following error when using OpenJDK 11

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Apparently, this will should be fixed with newer versions, so no problem, see google/guice#1133

[lucebac]

Btw, I am getting the following error when using OpenJDK 11

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Apparently, this will should be fixed with newer versions, so no problem, see google/guice#1133

I'm not seeing the illegal reflected access you mentioned. Could you tell me, when this happened? Guice is not a direct dependency of ModifiableVariable, nor does it seem to be a transitive dependency (according to mvn dependency:tree). Thus, I think you are just using an old version of maven that produces this errors on Java 11.

[jurajsomorovsky]

Yes, this seems to be only because of my mvn version:

Apache Maven 3.6.3
Maven home: /usr/share/maven
Java version: 14.0.1, vendor: Private Build, runtime: /usr/lib/jvm/java-14-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-51-generic", arch: "amd64", family: "unix"