Skip to content

Conversation

code2933
Copy link

@code2933 code2933 commented Oct 20, 2023

Description

This PR fixed the problem that command tldr --update does not work with proxy. These unresolved issues originate from the same reason:

It's a bug from axios that axios does not support HTTPS over HTTP proxy axios/axios#5037 (a dead PR).

This PR replaces axios with node-fetch with tiny changes.

Checklist

Please review this checklist before submitting a pull request.

  • Code compiles correctly
  • Created tests, if possible
  • All tests passing (npm run test:all)
  • Extended the README / documentation, if necessary

@kbdharun kbdharun added the hacktoberfest-accepted PRs which are eligible for hacktoberfest but won't get merged before 31st label Oct 24, 2023
@kbdharun kbdharun requested a review from MasterOdin October 24, 2023 16:54
Copy link
Contributor

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @code2933, could you please rebase your PR on the latest main?

@code2933
Copy link
Author

Hi @code2933, could you please rebase your PR on the latest main?

Working on it. Seems I did a wrong action. I will create a new PR when it's finished.

@code2933
Copy link
Author

Hey, I have merged previous commits and reopen this PR.

I have to note that I did not realize request timeout functionality which was introduced in PR #420 (see code here), since it's not a main feature from that PR, and I do not really know its necessity. I'm willing to add this functionality back if I'm wrong.

@code2933 code2933 reopened this Oct 26, 2023
@code2933 code2933 requested a review from MasterOdin October 26, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs which are eligible for hacktoberfest but won't get merged before 31st
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants