optimize core and react-wallet-kit #1090
Merged
+1,450
−1,109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 558949c:
|
moeodeh3
force-pushed
the
moeO/optimization
branch
from
92a8c49 to
20ccbca
Compare
|
amazing work, this is a giant improvement, hope this can be pr'd in soon! |
ethankonk
reviewed
Nov 17, 2025
amircheikh
reviewed
Nov 18, 2025
Contributor
|
This also makes me think, we need a spinner in our demo app when wallets is loading! 
|
moeodeh3
force-pushed
the
moeO/optimization
branch
from
55381c5 to
80ea306
Compare
Contributor
|
put the eslint ignore comment back for the QR code. Fixes build |
moeodeh3
force-pushed
the
moeO/optimization
branch
from
b5bb720 to
979de20
Compare
amircheikh
reviewed
Nov 21, 2025
| openSheet: (page: ModalPage) => void; | ||
| pushPage: (page: ModalPage) => void; | ||
| popPage: () => void; | ||
| popPages: (count: number) => void; |
moeodeh3
force-pushed
the
moeO/optimization
branch
from
979de20 to
558949c
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
amircheikh
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
our SDK loading times have been noticeably slow - something that’s easy to overlook here in North America, but for users elsewhere it can feel sluggish
this PR is our first step toward optimizing client initialization and session loading times to improve overall responsiveness
What this pr does:
httpClient@walletconnect/sign-clientwhich had some performance benefits (core)- reduce number of queries. Originally we did a fetchUser for each connected wallet, we now only do one
- parallelize list_wallets, list_wallet_accounts, list_user queries
- this added a new optional param
authenticatorAddressestofetchWalletAccounts()- adds
isLoadingattribute to the WalletConnect WalletProvider- when WalletConnect is done initializing (or it fails) we emit events that we listen for in
react-wallet-kitwhichrefreshes either the wallet or the walletProvider state (or both). We then handle this in our auth component
useCallback()and ensures each direct dependency is included. Indirect dependencies are not included (react-wallet-kit)below are video comparisons recorded while connected to a VPN in Europe:
Client initialization time:
before:
init-old.mov
after:
init-new.mov
Session loading time:
before:
old.mov
after:
new.mov
Also we see some benefits as well in NA, take a look:
before:
NA-old.mov
after:
NA-new.mov
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.